Test cases for addition, subtraction, multiplication, and modulo in the secp256k1 finite field#14
Open
weijiekoh wants to merge 2 commits into0xPARC:masterfrom
Open
Test cases for addition, subtraction, multiplication, and modulo in the secp256k1 finite field#14weijiekoh wants to merge 2 commits into0xPARC:masterfrom
weijiekoh wants to merge 2 commits into0xPARC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for addition, subtraction, multiplication, and modulo in the secp256k1 finite field. The circuits which perform these operations are in
test/circuitsand the test cases are defined insecp256k1_Fp.test.ts. The test cases are written in the same pattern as the other test files likebigint.test.ts.It also refactors the
bigint_to_array,bigint_to_tuple, andget_strided_bigintfunctions intotest/utils.tsto reduce code duplication.